Always enable default column feature, remove the configuration #4074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4074 +/- ##
============================================
- Coverage 66.86% 66.64% -0.23%
Complexity 20 20
============================================
Files 1035 1035
Lines 51434 51430 -4
Branches 7198 7198
============================================
- Hits 34393 34276 -117
- Misses 14668 14794 +126
+ Partials 2373 2360 -13
Continue to review full report at Codecov.
|
kishoreg
approved these changes
Apr 4, 2019
jackjlli
reviewed
Apr 4, 2019
| @@ -59,6 +59,7 @@ | |||
| import org.slf4j.Logger; | |||
| import org.slf4j.LoggerFactory; | |||
| import org.testng.annotations.BeforeClass; | |||
| import org.testng.annotations.Test; | |||
There was a problem hiding this comment.
This import never gets used though.
But since you're gonna delete this test, it should be good here.
The configuration is introduced to test the default column feature. Since it has been tested thoroughly for years, remove the configuration and always enable it.
Jackie-Jiang
force-pushed
the
default_column
branch
from
a68fe47
to
e42c52a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration is introduced to test the default column feature.
Since it has been tested thoroughly for years, remove the
configuration and always enable it.